Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Configurable Worker Pool for Transaction Processing #131

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JohnChangUK
Copy link

@JohnChangUK JohnChangUK commented Feb 16, 2025

Description

PR addresses the TODO comment in BuildSignAndSubmitTransactionsWithSignFunction regarding configurable buffer sizes.

  • This provides more predictable resource control and memory usage.

Test Plan

  • Ran integration tests against Devnet
  1. Integration Tests
    • Added two comprehensive integration tests in integration_test/transactionSubmission/
      • TestBuildSignAndSubmitTransactionsWithSignFnAndWorkerPoolWithOneSender
        • Tests single sender submitting multiple transactions
      • TestBuildSignAndSubmitTransactionsWithSignFnAndWorkerPoolWithMultipleSenders
        • Tests multiple concurrent senders
Screenshot 2025-02-16 at 16 31 43 Screenshot 2025-02-16 at 16 32 02

@JohnChangUK JohnChangUK requested review from gregnazario and a team as code owners February 16, 2025 22:17
Comment on lines +466 to +467
workerPoolConfig WorkerPoolConfig,
buildOptions ...any,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be able to put the WorkerPoolConfig in the ...any

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at what is passed in buildOptions, they are all blockchain TX related (MaxGasAmount, GasUnitPrice, ExpirationSeconds, SequenceNumber, ChainIdOption), therefore I think it'll be good to ahve these two as separate configs.

@gregnazario gregnazario enabled auto-merge (rebase) February 27, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants