Add Configurable Worker Pool for Transaction Processing #131
+354
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
approved these changes
Feb 18, 2025
Comment on lines
+466
to
+467
| workerPoolConfig WorkerPoolConfig, | ||
| buildOptions ...any, |
There was a problem hiding this comment.
You might be able to put the WorkerPoolConfig in the ...any
There was a problem hiding this comment.
Looking at what is passed in buildOptions, they are all blockchain TX related (MaxGasAmount, GasUnitPrice, ExpirationSeconds, SequenceNumber, ChainIdOption), therefore I think it'll be good to ahve these two as separate configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR addresses the TODO comment in
BuildSignAndSubmitTransactionsWithSignFunctionregarding configurable buffer sizes.Test Plan
integration_test/transactionSubmission/TestBuildSignAndSubmitTransactionsWithSignFnAndWorkerPoolWithOneSenderTestBuildSignAndSubmitTransactionsWithSignFnAndWorkerPoolWithMultipleSenders